Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pinning Chrome #5862

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Stop pinning Chrome #5862

merged 1 commit into from
Sep 25, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Sep 25, 2024

We initially did this because of some Bug in Chrome, but now the download of the very specific version here doesn't work any longer.

Let's see what happens if we don't pin.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

We initially did this because of some Bug in Chrome, but now the
download of the very specific version here doesn't work any longer.

Let's see what happens if we don't pin.
@mamhoff mamhoff requested a review from a team as a code owner September 25, 2024 13:44
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (7b4addf) to head (bf4ab87).
Report is 650 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5862   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files         752      752           
  Lines       17510    17510           
=======================================
  Hits        15625    15625           
  Misses       1885     1885           
Flag Coverage Δ
89.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tvdeyen tvdeyen merged commit 8182cb2 into solidusio:main Sep 25, 2024
14 checks passed
@mamhoff
Copy link
Contributor Author

mamhoff commented Dec 2, 2024

Please backport to 4.0, 4.1, 4.2, and 4.3...

@tvdeyen tvdeyen added backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 labels Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2
v4.3 Cherrypick failed because the selected commit (bf4ab87) is empty. Did you already backport this commit?

Manual backport

To create the backport manually run:

backport --pr 5862

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

github-actions bot commented Dec 2, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2
v4.3 Cherrypick failed because the selected commit (bf4ab87) is empty. Did you already backport this commit?

Manual backport

To create the backport manually run:

backport --pr 5862

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

github-actions bot commented Dec 2, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2
v4.3 Cherrypick failed because the selected commit (bf4ab87) is empty. Did you already backport this commit?

Manual backport

To create the backport manually run:

backport --pr 5862

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Copy link

github-actions bot commented Dec 2, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2
v4.3 Cherrypick failed because the selected commit (bf4ab87) is empty. Did you already backport this commit?

Manual backport

To create the backport manually run:

backport --pr 5862

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen tvdeyen removed the backport-v4.3 Backport this pull-request to v4.3 label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants