Add before action to handle option type params #5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvandoorn
force-pushed
the
fix-product-option-types-selector
branch
from
67e91d0 to
8002ab4
Compare
As reported in solidusio#5751, the new admin UI has a bug with the option type selectors: only one option type can be added. We narrowed this down to an issue handling option type params in the new admin products controller. We noticed legacy controller contains a before action to handle the incoming option type params, but the new one did not. Re-adding the before action solves the bug. This is required because the form input for option types contains comma separated values within a string: `<input value="1,2" type="hidden">` Co-authored-by: An Stewart <[email protected]> Co-authored-by: Kendra Chateau <[email protected]>
nvandoorn
force-pushed
the
fix-product-option-types-selector
branch
from
8002ab4 to
4f9903b
Compare
adammathys
approved these changes
Aug 9, 2024
kennyadsl
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As reported in #5751, the new admin UI has a bug with the option type selectors: only one option type can be added.
We narrowed this down to an issue handling option type params in the new admin products controller. We noticed legacy controller contains a before action to handle the incoming option type params, but the new one did not. Re-adding the before action solves the bug. This is required because the form input for option types contains comma separated values within a string:
<input value="1,2" type="hidden">Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: