-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CI): Set ESLINT_USE_FLAT_CONFIG=false #5721
Conversation
In ESLint v9 the flat config is default, but we can change the default back to the old one. See: eslint/eslint#18287
ah it's a shame we both worked on the same issue, I just submitted another one but did the upgrade to new configuration expected by eslint 9.0.0... #5722. Let me know what you think |
@loicginoux no, no shame :) Your is better, because I just disabled the new config format, while you updated it. Closing in favor of #5722 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5721 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 702 702
Lines 16698 16698
=======================================
Hits 14852 14852
Misses 1846 1846 ☔ View full report in Codecov by Sentry. |
@solidusio/core-team I reopened the PR because it solves the issue for now and #5722 seems to need more work. |
We need to backport this to all maintained Solidus version I guess. Which one are those? |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
In ESLint v9 the flat config is default, but we can change the default back to the old one.
See: eslint/eslint#18287