Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): Set ESLINT_USE_FLAT_CONFIG=false #5721

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 12, 2024

In ESLint v9 the flat config is default, but we can change the default back to the old one.

See: eslint/eslint#18287

In ESLint v9 the flat config is default, but we can change the
default back to the old one.

See: eslint/eslint#18287
@tvdeyen tvdeyen requested a review from a team as a code owner April 12, 2024 09:09
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Apr 12, 2024
@tvdeyen tvdeyen added backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 and removed changelog:repository Changes to the repository not within any gem labels Apr 12, 2024
@tvdeyen tvdeyen added the changelog:repository Changes to the repository not within any gem label Apr 12, 2024
@loicginoux
Copy link
Contributor

ah it's a shame we both worked on the same issue, I just submitted another one but did the upgrade to new configuration expected by eslint 9.0.0... #5722. Let me know what you think

@tvdeyen tvdeyen mentioned this pull request Apr 12, 2024
3 tasks
@tvdeyen
Copy link
Member Author

tvdeyen commented Apr 12, 2024

@loicginoux no, no shame :) Your is better, because I just disabled the new config format, while you updated it.

Closing in favor of #5722

@tvdeyen tvdeyen closed this Apr 12, 2024
@tvdeyen tvdeyen deleted the fix-eslint branch April 12, 2024 09:14
@tvdeyen tvdeyen restored the fix-eslint branch April 12, 2024 10:18
@tvdeyen tvdeyen reopened this Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (a2e1519) to head (2d5296f).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5721   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files         702      702           
  Lines       16698    16698           
=======================================
  Hits        14852    14852           
  Misses       1846     1846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen
Copy link
Member Author

tvdeyen commented Apr 12, 2024

@solidusio/core-team I reopened the PR because it solves the issue for now and #5722 seems to need more work.

@tvdeyen
Copy link
Member Author

tvdeyen commented Apr 12, 2024

We need to backport this to all maintained Solidus version I guess. Which one are those?

@tvdeyen tvdeyen added backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 and removed backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 labels Apr 17, 2024
@tvdeyen tvdeyen merged commit 3f6c58c into solidusio:main Apr 17, 2024
32 of 35 checks passed
@tvdeyen tvdeyen deleted the fix-eslint branch April 17, 2024 12:07
Copy link

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.3 Backport this pull-request to v4.3 changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants