Add missing option types to product sample data #5638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_sample
Sample products data was reworked with solidusio/pull/5437. After these changes, some products with variants remained without option types, meaning that their variants remained not visible and selectable on the FE, and in the admin it was not possible to add new ones as the relevant button was hidden.
spaghetticode
force-pushed
the
spaghetticode/add-missing-product-option-types
branch
from
4566b49 to
55ecd5b
Compare
rainerdema
approved these changes
Feb 2, 2024
spaghetticode
deleted the
spaghetticode/add-missing-product-option-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sample products data was reworked with /pull/5437. After these changes, some products with variants remained without option types, meaning that their variants remained not visible and selectable on the FE, and in the admin it was not possible to add new ones as the relevant button was hidden.
Sample products with variants are visible here: https://github.com/solidusio/solidus/blob/main/sample/db/samples/variants.rb
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: