Fix the check on select2 translations asset existence #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_backend
elia
force-pushed
the
elia/fix-select2-locales-loading-with-precompiled-assets
branch
from
27af7cb to
f7c776a
Compare
github-actions
bot
added
the
changelog:repository
elia
force-pushed
the
elia/fix-select2-locales-loading-with-precompiled-assets
branch
from
f7c776a to
818552f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5582 +/- ##
==========================================
+ Coverage 88.31% 88.63% +0.31%
==========================================
Files 116 683 +567
Lines 2217 16299 +14082
==========================================
+ Hits 1958 14446 +12488
- Misses 259 1853 +1594 ☔ View full report in Codecov by Sentry. |
|
Needs a rebase? |
In environment expecting precompiled assets `Rails.application.assets` is `nil` and we should fall back on checking the manifest.
elia
force-pushed
the
elia/fix-select2-locales-loading-with-precompiled-assets
branch
from
818552f to
8f997be
Compare
github-actions
bot
removed
the
changelog:repository
elia
deleted the
elia/fix-select2-locales-loading-with-precompiled-assets
branch
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In environment expecting precompiled assets
Rails.application.assetsisniland we should fall back on checking the manifest.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: