Fix property destroy - use destroy instead of discard #5577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonxyx
commented
Dec 29, 2023
| @@ -6,19 +6,19 @@ | |||
| before { sign_in create(:admin_user, email: '[email protected]') } | |||
|
|
|||
| it "lists properties and allows deleting them" do | |||
| create(:property, name: "Type", presentation: "Type") | |||
| create(:property, name: "Type prop", presentation: "Type prop") | |||
There was a problem hiding this comment.
Changed "Type" to "Type prop" because of text Option types" used for the menu item which test recognizes as non deleted.
jarednorman
approved these changes
Dec 31, 2023
kennyadsl
approved these changes
Jan 2, 2024
|
@elia @rainerdema I think we need to backport this to 4.3, adding the appropriate label. |
elia
added
backport-v4.3
elia
approved these changes
Jan 2, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
|
@kennyadsl I just realized the PR is for solidus admin only, meaning that we don't need the back port since we can release independently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
Spree::Propertyobject is not discardable, use the defaultdestroy_allmethodFixes #5576