Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the customer returns specs leverage time outs #5569

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Ensure the customer returns specs leverage time outs #5569

merged 1 commit into from
Dec 27, 2023

Conversation

elia
Copy link
Member

@elia elia commented Dec 27, 2023

Summary

This is the most probable cause of previous flakyness, having a check on an element without giving the UI time to update.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia
Ensure the customer returns specs leverages time outs
a14176f 
This is the most probable cause of previous flakyness.
@elia elia self-assigned this Dec 27, 2023
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Dec 27, 2023
@elia elia marked this pull request as ready for review December 27, 2023 11:24
@elia elia requested a review from a team as a code owner December 27, 2023 11:24
@elia elia requested a review from kennyadsl December 27, 2023 11:25
@kennyadsl kennyadsl merged commit d86d7bb into main Dec 27, 2023
11 checks passed
@kennyadsl kennyadsl deleted the elia/flakey-spec-fix branch December 27, 2023 11:27
@elia elia changed the title Ensure the customer returns specs leverages time outs Ensure the customer returns specs leverage time outs Dec 27, 2023
@elia elia added changelog:skip Changes that we don't want to be listed in the Changelog and removed changelog:solidus_backend Changes to the solidus_backend gem labels Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees

@elia elia

Labels
changelog:skip Changes that we don't want to be listed in the Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @kennyadsl