Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Reuse the same class name as Backend for MenuItem #5555

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

elia
Copy link
Member

@elia elia commented Dec 19, 2023

Summary

Match the name in Backend to make it easier to reason about it.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:repository Changes to the repository not within any gem labels Dec 19, 2023
@github-actions github-actions bot removed changelog:solidus_core Changes to the solidus_core gem changelog:repository Changes to the repository not within any gem labels Dec 19, 2023
@elia elia force-pushed the elia/menu-item branch 3 times, most recently from 4e73fd8 to 314db5d Compare December 19, 2023 16:17
Match the name in Backend to make it easier to reason about it.
@elia elia marked this pull request as ready for review December 19, 2023 16:25
@elia elia requested a review from a team as a code owner December 19, 2023 16:25
@elia elia requested a review from rainerdema December 19, 2023 16:25
@elia elia merged commit 9e34e3c into main Dec 19, 2023
8 checks passed
@elia elia deleted the elia/menu-item branch December 19, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants