Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Performance fixes #5552

Merged
merged 4 commits into from
Dec 13, 2023
Merged

[admin] Performance fixes #5552

merged 4 commits into from
Dec 13, 2023

Conversation

elia
Copy link
Member

@elia elia commented Dec 13, 2023

Summary

A few fixes that came out of trying the new admin on an established store.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Dec 13, 2023
@github-actions github-actions bot added changelog:repository Changes to the repository not within any gem changelog:solidus_admin labels Dec 13, 2023
elia and others added 4 commits December 13, 2023 19:25
Fetching all the variants was too expensive for stores with hundreds
or thousands of them.

Co-Authored-By: Rainer Dema <[email protected]>
@elia elia force-pushed the elia+rainer/solidus-admin-fixes branch from bcbd6d7 to 2b857af Compare December 13, 2023 18:25
@github-actions github-actions bot removed the changelog:repository Changes to the repository not within any gem label Dec 13, 2023
@elia elia requested a review from rainerdema December 13, 2023 18:26
@elia elia marked this pull request as ready for review December 13, 2023 18:26
@elia elia requested a review from a team as a code owner December 13, 2023 18:26
@rainerdema rainerdema merged commit 6820333 into main Dec 13, 2023
8 checks passed
@rainerdema rainerdema deleted the elia+rainer/solidus-admin-fixes branch December 13, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants