Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] Update the admin preview toggle label #5515

Merged
merged 15 commits into from
Nov 22, 2023
Merged

[admin] Update the admin preview toggle label #5515

merged 15 commits into from
Nov 22, 2023

Conversation

elia
Copy link
Member

@elia elia commented Nov 21, 2023 •
edited
Loading

Summary

Extracted fixes from the work on the adjustments index page.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Nov 21, 2023
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin labels Nov 21, 2023
@elia elia force-pushed the elia/misc-improvements branch from 79ca4c5 to fe0a0ce Compare November 22, 2023 10:40
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Nov 22, 2023
@elia elia force-pushed the elia/misc-improvements branch from fe0a0ce to 39bba93 Compare November 22, 2023 10:50
@elia elia marked this pull request as ready for review November 22, 2023 10:50
@elia elia requested a review from a team as a code owner November 22, 2023 10:50
elia added 10 commits November 22, 2023 11:56
@elia
Restore creating a new order from the new admin dashboard
bd9e048
@elia
Extract a ui/dropdown component from ui/panel
d2a637b
@elia
Improve row clicking for the ui/table component
b9c85c6 
- Use stimulus params instead of arbitrary data attributes
- Only attach the url if the url proc is defined
- Improve detection of default-clickable elements for which the row
  url shouldn't be used
@elia
Add a spec for managing order addresses
1057b1a
@elia
Allow thumbnails to contain an icon
9c03173
@elia
Add a .for method to ui/thumbnail with a standard icon/image for …
7c2314e 
…each model
@elia
Fix calling Set#sample in the ui/icon component
a290b96
@elia
Add standard Rails meta tags and fix turbo-rails data attributes
b2d1145 
This is why `data-turbo-method` wasn't working.
@elia
Memoize the country object instead of the id
5341f35 
Should save one or two extra roundtrips to the database.
@elia
Allow to opt-out of cell-wrapping in ui/table
bf0c431 
Also changes how `<col>` attributes are provided.
@elia elia force-pushed the elia/misc-improvements branch 2 times, most recently from 75bbf83 to bbade9b Compare November 22, 2023 11:29
@elia elia force-pushed the elia/misc-improvements branch from bbade9b to 96e9efd Compare November 22, 2023 11:41
@elia elia force-pushed the elia/misc-improvements branch from c2f2aed to 854301d Compare November 22, 2023 14:21
@elia elia merged commit 67a40c1 into main Nov 22, 2023
8 checks passed
@elia elia deleted the elia/misc-improvements branch November 22, 2023 15:15
@elia elia changed the title [admin] Misc improvements [admin] Update the admin preview toggle label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

Assignees

@elia elia

Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @rainerdema