-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[admin] Add the customer sidebar to the orders page #5499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/admin/orders-customer-sidebar
branch
3 times, most recently
from
November 3, 2023 14:42
c087e23
to
92d73d6
Compare
Codecov Report
@@ Coverage Diff @@
## main #5499 +/- ##
=======================================
Coverage 88.93% 88.93%
=======================================
Files 622 622
Lines 14909 14918 +9
=======================================
+ Hits 13259 13268 +9
Misses 1650 1650
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
elia
force-pushed
the
elia/admin/orders-customer-sidebar
branch
from
November 3, 2023 15:06
92d73d6
to
77b9f54
Compare
rainerdema
reviewed
Nov 3, 2023
elia
force-pushed
the
elia/admin/orders-customer-sidebar
branch
2 times, most recently
from
November 6, 2023 09:36
4a13a62
to
03713b4
Compare
rainerdema
reviewed
Nov 6, 2023
admin/app/components/solidus_admin/orders/show/component.html.erb
Outdated
Show resolved
Hide resolved
elia
force-pushed
the
elia/admin/orders-customer-sidebar
branch
from
November 6, 2023 14:23
03713b4
to
7a4861a
Compare
This avoids a flickering when closing modals coming back to the underlying page.
elia
force-pushed
the
elia/admin/orders-customer-sidebar
branch
from
November 6, 2023 14:26
7a4861a
to
0dda932
Compare
github-actions
bot
added
the
changelog:solidus_core
Changes to the solidus_core gem
label
Nov 6, 2023
rainerdema
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The backdrop no longer uses blurring and the color/transparency is as expected:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: