Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Add the customer sidebar to the orders page #5499

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

elia
Copy link
Member

@elia elia commented Nov 3, 2023

Summary

address open menu
image image

The backdrop no longer uses blurring and the color/transparency is as expected:

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Nov 3, 2023
@elia elia force-pushed the elia/admin/orders-customer-sidebar branch 3 times, most recently from c087e23 to 92d73d6 Compare November 3, 2023 14:42
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #5499 (0dda932) into main (a8c1d8a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5499   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files         622      622           
  Lines       14909    14918    +9     
=======================================
+ Hits        13259    13268    +9     
  Misses       1650     1650           
Files Coverage Δ
...pp/components/solidus_admin/layout/page_helpers.rb 100.00% <100.00%> (ø)
.../components/solidus_admin/orders/show/component.rb 100.00% <100.00%> (ø)
...controllers/solidus_admin/line_items_controller.rb 100.00% <100.00%> (ø)
...app/controllers/solidus_admin/orders_controller.rb 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@elia elia marked this pull request as ready for review November 3, 2023 14:52
@elia elia requested a review from a team as a code owner November 3, 2023 14:52
@elia elia requested a review from rainerdema November 3, 2023 14:52
@elia elia force-pushed the elia/admin/orders-customer-sidebar branch from 92d73d6 to 77b9f54 Compare November 3, 2023 15:06
@elia elia requested a review from rainerdema November 6, 2023 09:09
@elia elia force-pushed the elia/admin/orders-customer-sidebar branch 2 times, most recently from 4a13a62 to 03713b4 Compare November 6, 2023 09:36
@elia elia force-pushed the elia/admin/orders-customer-sidebar branch from 03713b4 to 7a4861a Compare November 6, 2023 14:23
@elia elia force-pushed the elia/admin/orders-customer-sidebar branch from 7a4861a to 0dda932 Compare November 6, 2023 14:26
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 6, 2023
@elia elia requested a review from rainerdema November 6, 2023 14:32
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@elia elia merged commit eab114b into main Nov 6, 2023
4 checks passed
@elia elia deleted the elia/admin/orders-customer-sidebar branch November 6, 2023 14:45
@elia elia restored the elia/admin/orders-customer-sidebar branch November 6, 2023 15:27
@elia elia removed the changelog:solidus_core Changes to the solidus_core gem label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants