Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic ui/toggletip positioning #5451

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Dynamic ui/toggletip positioning #5451

merged 2 commits into from
Oct 27, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 24, 2023

Summary

This is a basic version that prevents a toggle tip that's slightly outside of the page to be adjusted.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Oct 24, 2023
@elia elia requested a review from rainerdema October 24, 2023 14:08
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #5451 (2a631bc) into main (af2803a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5451   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         614      614           
  Lines       14830    14830           
=======================================
  Hits        13186    13186           
  Misses       1644     1644           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review October 25, 2023 12:08
@elia elia requested a review from a team as a code owner October 25, 2023 12:08
@elia elia merged commit b653f69 into main Oct 27, 2023
4 checks passed
@elia elia deleted the elia/dynamic-toggletip branch October 27, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants