Update hints and remove them where not needed #5435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Oct 13, 2023
| promotionable_html: 'This determines whether or not promotions can apply to this product.<br>Default: Checked' | ||
| shipping_category_html: 'This determines what kind of shipping this product requires.<br> Default: Default' | ||
| tax_category_html: 'This determines what kind of taxation is applied to this product.<br> Default: %{default_tax_category}' | ||
| available_on_html: Choose a product availability date |
There was a problem hiding this comment.
Can you explain why these texts have been updated? I think these are valuable informations for the user. Is this information displayed somewhere else now?
Hints that display in tooltip have to be clear and concise. Fields that might have a critical effect to product creation are always visible under the field. Hints that don't give relevant suggestions, have been removed.
mfrecchiami
force-pushed
the
mfrecchiami/hints-update
branch
from
30a0d8d to
590a7ac
Compare
tvdeyen
approved these changes
Oct 16, 2023
jarednorman
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hints are displayed in tooltips and have to be clear and concise. Hints also have to give relevant suggestions that's why the SEO hint has been removed.
Some hints might seem obvious but these are crucial, especially when a new product is launched. We are referring to these two in particular:
available_onanddiscontinue_onwhich can be confusing and could generate unwanted mistakes.The quickest solution we want to implement in this phase is to show these hints as a visible field description (a hint in a
<span>instead of a hint in a tooltip).We've also reduced the verbosity of the two phrases, to get a message that is clear and immediate (ideally not more than two rows).
Summary
Fixes: SOL-765
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: