Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the version of chrome to install until the ORB is fixed #5367

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

elia
Copy link
Member

@elia elia commented Sep 4, 2023

Ref:

Once merged I'll immediately open a revert PR for the first commit so we'll make sure we don't stay on chrome v114 forever.

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Sep 4, 2023
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Sep 4, 2023
@elia elia force-pushed the elia+rainer/admin/chrome-fix branch 2 times, most recently from 51aced2 to 6c7ed7b Compare September 4, 2023 10:02
After the updated ubuntu version kicked in libffi7 has been replaced
by libffi8, so we need to reinstall the gem altogether.

Ref: https://askubuntu.com/a/1300763
@elia elia force-pushed the elia+rainer/admin/chrome-fix branch from 487e50f to 7f2ddc6 Compare September 4, 2023 11:37
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #5367 (7f2ddc6) into main (d095e38) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5367   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files         563      563           
  Lines       13896    13896           
=======================================
  Hits        12328    12328           
  Misses       1568     1568           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia requested a review from rainerdema September 4, 2023 12:11
@elia elia marked this pull request as ready for review September 4, 2023 12:11
@elia elia requested a review from a team as a code owner September 4, 2023 12:11
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elia elia merged commit 355267a into main Sep 4, 2023
11 checks passed
@elia elia deleted the elia+rainer/admin/chrome-fix branch September 4, 2023 12:20
@elia
Copy link
Member Author

elia commented Sep 4, 2023

Forced the merge in order to fix the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants