Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Adim] Fix parameter name in the select component #5366

Merged
merged 1 commit into from
Sep 4, 2023
Merged

[Adim] Fix parameter name in the select component #5366

merged 1 commit into from
Sep 4, 2023

Conversation

waiting-for-dev
Copy link
Contributor

Summary

#5363 was merged just before #5360, so it didn't pick up the rename.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev
Fix parameter name in the select component
95e9c3c 
solidusio#5363 was merged just before
solidusio#5360, so it didn't pick up the
rename.
@waiting-for-dev waiting-for-dev requested a review from a team as a code owner September 1, 2023 04:52
@waiting-for-dev waiting-for-dev self-assigned this Sep 1, 2023
@waiting-for-dev waiting-for-dev added the type:bug Error, flaw or fault label Sep 1, 2023
rainerdema
rainerdema approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rainerdema
Copy link
Contributor

@waiting-for-dev We're experiencing a 404 error in the CI/CD pipeline while trying to fetch ChromeDriver 🤔

@waiting-for-dev
Copy link
Contributor Author

The CI failure is related to CircleCI-Public/browser-tools-orb#72 I tried the recommended workarounds with no luck

elia
elia approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge, the CI brake is clearly unrelated 👍

@elia elia merged commit 9809efc into solidusio:nebulab/admin Sep 4, 2023
5 of 10 checks passed
@elia elia deleted the waiting-for-dev/admin/fix_select branch September 4, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

@rainerdema rainerdema rainerdema approved these changes

@the-krg the-krg Awaiting requested review from the-krg

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_admin type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waiting-for-dev @rainerdema @elia