Skip to content

Commit

Permalink
Restrict sqlite3 for the extension generator
Browse files Browse the repository at this point in the history
The task itself is fine, as it inherits from
Rails' app generator, which has the sqlite3 restriction:
https://github.com/rails/rails/blob/main/railties/lib/rails/generators/database.rb#L19.

(cherry picked from commit e85fd4c)

# Conflicts:
#	.circleci/config.yml
  • Loading branch information
mamhoff committed Dec 2, 2024
1 parent 93d2e13 commit 0238832
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,9 @@ commands:
mkdir -p /tmp/dummy_extension
cd /tmp/dummy_extension
bundle init
bundle add rails sqlite3 <<parameters.extra_gems>> --skip-install
bundle add solidus --git "file://$(ruby -e"puts File.expand_path ENV['CIRCLE_WORKING_DIRECTORY']")"
bundle add rails -v "< 7.1" --skip-install
bundle add sqlite3 -v "~> 1.3" --skip-install
test -n "<<parameters.extra_gems>>" && bundle add <<parameters.extra_gems>> --skip-install
export LIB_NAME=set # dummy requireable file
bundle exec rake -rrails -rspree/testing_support/extension_rake -e'Rake::Task["extension:test_app"].invoke'
Expand Down

0 comments on commit 0238832

Please sign in to comment.