Skip to content

Add docs for configurable event subscribers #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

benjaminwil
Copy link
Contributor

@benjaminwil benjaminwil commented May 21, 2025

Summary

Built-in Solidus event subscribers are now configurable since solidusio/solidus#6234 was merged. The docs added by this pull request help users understand how to add or remove built-in event subscribers in their applications.

Checklist

  • I have followed the Diátaxis framework in my PR.
  • I have verified that the preview environment works correctly.

@benjaminwil
Copy link
Contributor Author

The preview environment has not yet been generated, so I can't complete the checklist yet.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@benjaminwil
Copy link
Contributor Author

The expected Cloudflare Pages check does not seem to be running against any of the currently open pull requests.

It is unclear whether this is because a core committer needs to allow the check to run from an untrusted collaborator or whether something is broken.

@benjaminwil
Copy link
Contributor Author

The Cloudflare Pages preview hasn't built as far as I can tell. But I manually verified that the documentation is rendering well locally.

The documentation added as part of this PR rendering well in development mode

@benjaminwil
Copy link
Contributor Author

CCing people from the core team who might know. @tvdeyen @kennyadsl @jarednorman

I've grepped this repository for "cloudflare" and haven't found any information about how to make the Cloudflare Pages previews work. Setting that aside, I think this pull request is mergable.

@tvdeyen tvdeyen merged commit 1e3edfe into solidusio:main May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants