Move authentication method configuration to sidebar settings.#132
Move authentication method configuration to sidebar settings.#132rahulsingh321 wants to merge 2 commits intosolidusio-contrib:masterfrom
Conversation
96c7c03 to
8053931
Compare
|
@kennyadsl please Review PR with some Last minor changes to social. Tests fail only on sqlite. |
|
@rahulsingh321 can you please post some screenshots of the visual part of the change? |
@kennyadsl I added the screenshots of the view now, please have a look when you get chance. |
|
Am I right that we are using the legacy/classic admin style in the new admin namespace? Any reason why not using the new style (the one with tailwind)? |
@kennyadsl Just to provide support for legacy front-end, I didn't use the tailwind UI. If we don't need that, let me know, I can update that. |
|
@kennyadsl I would avoid the line break and call it oauth login if that's ok. |
|
I'd go with Social Auth or Social Login |
@rahulsingh321 please rename the settings menu label to |
@kennyadsl can we fix new admin in a later release given that it's not a setting that you set every day? |
|
@rahulsingh321 tests still failing |
e4ed0d4 to
3247c36
Compare
|
@kennyadsl tests are fixed and changes implemented. Ruby 3.0 sqlite is tested, I already raised the question to Jared. Do we still want to test for that? |
3247c36 to
0d25953
Compare
|
@tvdeyen this one as well? |
Issue: #131
Listing view:

Edit View
