Respect vite ssr option in first place when transforming.
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFoxPro
changed the title
MrFoxPro
changed the title
ssr option in first place when transforming.
MrFoxPro
force-pushed
the
respect-vite-ssr
branch
from
22da773
to
17d67b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the case: some tool need to load module with Solid JSX. I hit this problem two times: in Vite plugin for prerendering certain pages, and now with css-in-js plugin, because I need to extract css from module.
It's impossible to
ssrLoadModuleif neitherssr: truenorsolid: { generate: 'ssr' }is explicitly set. At the same time, I don't need to generate SSR bundle for whole app, otherwise it will break my app.Related #64