fix: createSignal not found when bundled #1964
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances a global function export (like
createSignal
) can be transformed by rollup into a let binding, which will break the global evaluation oftransPending
since thencreateSignal
will be defined after being used.I.e. the code from
signal.ts
which looks like this:will be translated to
which obviously won't work anymore since the let definition isn't hoisted.
While I believe this bug should fundamentally be solved in rollup itself this is a quick, rather painless fix (it's interesting that rollup isn't smart enough to reason about in-file dependencies in this way)
How did you test this change?
The app that this came up in is still closed-source unfortunately, and this bug - being a codegen-bug - proofed itself to be hard to reproduce, but I hope the above reasoning is easy enough to follow.