Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DEV): Add afterCreateSignal hook to DevHooks #1960

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

thetarnav
Copy link
Contributor

A hook called whenever a new signal is created will allow to

  1. track the amount of signals in use, compared to the amount of owners, to see the impact of using signals and stores for state management on overall memory use. Discovering memory leaks, and where signals are wastefully created.
  2. track the state of signals created outside of owners, eg when doing a simple global state.

Copy link

changeset-bot bot commented Nov 18, 2023

🦋 Changeset detected

Latest commit: aabc93c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid ryansolid merged commit b092368 into solidjs:main Nov 22, 2023
1 check passed
@thetarnav thetarnav deleted the after-create-signal-hook branch November 22, 2023 23:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6963478073

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 93.486%

Files with Coverage Reduction New Missed Lines %
packages/solid/src/reactive/signal.ts 14 93.1%
Totals Coverage Status
Change from base Build 6696199956: 0.005%
Covered Lines: 4148
Relevant Lines: 4368

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants