Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types directory export for each package #1948

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

thetarnav
Copy link
Contributor

@thetarnav thetarnav commented Nov 7, 2023

When selecting a "moduleResolution" option is tsconfig other than "node" you cannot import the other not-exported from main modules types, which is useful for importing a very specific internal type, eg in devtools. 🙃

Screenshot from 2023-11-07 18-35-55

But when the types directories are explicitly exported one can import a specific .d.ts file.

image

Another solution would be to export every internal type from main modules, which is fine too.

Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: dfed026

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid ryansolid added the typescript relating to typescript or types label Nov 21, 2023
@ryansolid ryansolid merged commit 2b32037 into solidjs:main Nov 22, 2023
1 check passed
@ryansolid
Copy link
Member

Thanks

@thetarnav thetarnav deleted the types-exports branch November 22, 2023 23:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6963448390

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 93.482%

Files with Coverage Reduction New Missed Lines %
packages/solid/src/reactive/signal.ts 14 93.09%
Totals Coverage Status
Change from base Build 6696199956: 0.001%
Covered Lines: 4145
Relevant Lines: 4365

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript relating to typescript or types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants