Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing indexArray to server-side runtime. #1920

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

thetarnav
Copy link
Contributor

  • Add missing indexArray to server-side runtime.
  • prevent cannot access property "length" of undefined when passing undefined to mapArray on the server

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

🦋 Changeset detected

Latest commit: b1c36d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines -282 to -284
function getSymbol() {
const SymbolCopy = Symbol as any;
return SymbolCopy.observable || "@@observable";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi I got rid of this because it wasn't used anywhere

@ryansolid
Copy link
Member

Looks good thanks.

@ryansolid ryansolid merged commit b632dfd into solidjs:main Oct 16, 2023
1 check passed
@thetarnav thetarnav deleted the server-index-array branch October 23, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants