feat: include server function id in the request URL#2251
Open
birkskyum wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: d977d82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
Member
|
Hmmm this needs discussion. Pre-1.0 we had this kind of format then shifted to what we have today. I'm honestly fine with this change, but perhaps @ryansolid can weigh in on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1795
Server function calls all went to a single
_serverURL, so access logs, traces and the network panel collapsed every function into one entry.Requests now go to
_server/<id>. In development the id ends with the source name, so you getPOST /_server/13375fbc-0-pingwith no configuration.Production ids stay opaque by default. Opt in to keep the names:
Notes:
action.urlchanges from/_server?id=<id>to/_server/<id>. The handler still accepts the?id=form, so hand-written URLs keep working.pathname.startsWith("/_server"), which also matched unrelated routes like/_serverless. It is now an exact match on/_serveror a/_server/prefix.Tested: 12 new unit tests for the URL helpers, both e2e suites pass (30/30 dev, 30/30 bundled-dev), and verified against a production build that the new URL, the legacy
?id=URL, andreadableIdsall behave as expected.