upgrade: scroll package upgrade for Solid 2.0#857
Open
davedbase wants to merge 7 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: a5b9a8c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jer3m01
reviewed
May 14, 2026
Member
jer3m01
left a comment
jer3m01
left a comment
There was a problem hiding this comment.
Looks good, few things I'd change by preference. Also make sure to use signal refs.
atk
approved these changes
May 15, 2026
| */ | ||
| export function getScrollPosition(target: Element | Window | undefined): Position { | ||
| if (isServer || !target) { | ||
| return { ...FALLBACK_SCROLL_POSITION }; |
Member
There was a problem hiding this comment.
Why putting the fallback in a new object every time? It is already read-only according to TS. Why not just return it as is?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@solid-primitives/scrollto Solid.js v2.0 (beta.10). UpdatesisServerimport to@solidjs/web, replacesonMount/sharedConfig.contextwith their Solid 2.0 equivalents, and rewrites the internal scroll-trigger mechanism to avoid the newcreateSignal(fn)derived-signal semantics. Tests updated to useflush()for batched-update assertions.createPreventScrollto@solid-primitives/scroll— prevents scrolling outside a given element by interceptingwheelandtouchmoveevents and optionally hiding the<body>scrollbarsrc/index.tsintosrc/scrollPosition.tsandsrc/preventScroll.ts;index.tsis now a clean barrel re-export@solidjs/web,flush()in tests,ownedWrite, splitcreateEffect)Attribution
createPreventScrollis adapted from solid-prevent-scroll by Jasmin Noetzli (GiyoMoon), part of the corvu project, which is itself inspired by react-remove-scroll by Anton Korzunov. Both are credited inLICENSEandpackage.json.createPreventScrollAPIMultiple active instances stack; only the topmost installs event listeners. Body styles are shared and only restored once all instances clean up.