Fix production bugs

Bugs discovered while deploying the service to production:
- URIs with # in .env need to be quoted
- ctx.response.body is not a function; need assignment

Update README
and a random .vscode settings change

.env.sample

@@ -13,7 +13,7 @@ BEHIND_PROXY=
 MAILER_IDENTITY_EMAIL=bot@example
 MAILER_IDENTITY_PASSWORD=password
 MAILER_IDENTITY_PROVIDER=http://localhost:3456
-MAILER_IDENTITY_WEBID=http://localhost:3456/bot/profile/card#me
+MAILER_IDENTITY_WEBID="http://localhost:3456/bot/profile/card#me"
 MAILER_IDENTITY_CSS_VERSION=7 # supported versions are 6 and 7
 
 # link to group of users who are allowed to use the service
@@ -44,4 +44,4 @@ JWT_KEY=./ecdsa-p256-private.pem
 JWT_ALG=ES256
 
 # type index class by which we find settings with email
-EMAIL_DISCOVERY_TYPE=http://w3id.org/hospex/ns#PersonalHospexDocument
+EMAIL_DISCOVERY_TYPE="http://w3id.org/hospex/ns#PersonalHospexDocument"

.vscode/settings.json

@@ -2,6 +2,6 @@
   "editor.defaultFormatter": "esbenp.prettier-vscode",
   "editor.formatOnSave": true,
   "editor.codeActionsOnSave": {
-    "source.organizeImports": true
+    "source.organizeImports": "explicit"
   }
 }

README.md

@@ -27,7 +27,9 @@ Email address and verification token should be stored in (webId) - space:prefere
 
 To authenticate itself, the mailer needs to have its own identity, it can be identity hosted on some Community Solid Server
 
-Copy `.env.sample` to `.env` and edit the latter according to your needs
+Copy `.env.sample` to `.env` and edit the latter according to your needs.
+
+_:warning: If you provide URIs with `#``, put them to `""`, otherwise # may be interpreted as comment!_
 
 Alternatively, you may provide the configuration as environment variables
 

src/controllers/integration.ts

@@ -92,11 +92,11 @@ export const finishIntegration: Middleware = async ctx => {
   if (savedTokensCount === 0) {
     ctx.response.status = 400
     ctx.set('content-type', 'application/json')
-    ctx.response.body({
+    ctx.response.body = {
       error:
-        "We could't find any writeable location on your Pod to save the email verifiation token. You can write it manually.",
+        "We couldn't find any writeable location on your Pod to save the email verifiation token. You can write it manually.",
       token: jwt,
-    })
+    }
   } else {
     ctx.response.body = jwt
     ctx.set('content-type', 'text/plain')