This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
sol-connman: Add sol-connman basic API #1905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the comments of #1848,
Please review it again. Thanks. |
wzhen12
force-pushed
the
master
branch
2 times, most recently
from
644f65a
to
7b2bd76
Compare
| * the service has been removed in the system. | ||
| */ | ||
| enum sol_connman_service_state { | ||
| SOL_CONNMAN_SERVICE_STATE_UNKNOWN = 0, |
There was a problem hiding this comment.
add the documentation about each state using the format:
enum sol_connman_service_state {
/**
* @brief the service is idle (what does this mean?)
*
* a service is idle when situation X, Y and Z occur.
*/Provide details on the meaning, like REMOVE should mention that the service handle (pointer) will become invalid.
|
we're almost there! just very minor issues. Also, remember to rename |
so-connman is for implementing connection manager features. The APIs should be implemented in Zephyr, connman and so on. To connman, the connman D-Bus APIs are wrapped in the so-connman APIs. The user can use the so-connman APIs to control connman. To invoke the D-Bus method of connman, the async call is used, the callback function is set to get the results of async call. The basic so-connman APIs are in the patch. It provides the APis of getting the name, ip address... of services. The service connect/disconnect APIs and set/get offline are implemented too. The further sol-connman APIs are being planned. Signed-off-by: Wu Zheng <[email protected]>
Get the service properties APIs are implemented. It based on connman and wraps the D-Bus APIs of connman services. Get the name, state, type, ip address ... of services are done. Signed-off-by: Wu Zheng <[email protected]>
sol-connman init/shutdown are implemented. It based on connman and wraps the D-Bus APIs of connman. init/shutdown are not true to init/shutdown sol-connman. init_lazy/shutdown_lazy are true to init/shutdown sol-connman. Signed-off-by: Wu Zheng <[email protected]>
sol-connman set offline are implemented. It based on connman and wraps the D-Bus APIs of connman. It sets the connman to offline mode. It will close the all connection interfaces(including ethernet ...). Signed-off-by: Wu Zheng <[email protected]>
Get connection manager state is implemented. It based on connman and wraps the D-Bus APIs of connman. Get connection manager state are from connman. It includes online, ready, offline, idle. Signed-off-by: Wu Zheng <[email protected]>
Get services properties is implemented. It based on connman and wraps the D-Bus APIs of connman. It only is invoked internal and in the process of init lazy. Get services properties APIs can't invoke the D-Bus APIs of connman directly. Signed-off-by: Wu Zheng <[email protected]>
add/del monitor are implemented. It based on connman and wraps the D-Bus APIs of connman. Monitor the connman services and connection manager state changed. Signed-off-by: Wu Zheng <[email protected]>
callback are implemented. It based on connman and wraps the D-Bus APIs of connman. When add Monitor, callback function is registered. when any services properties and connection manager state are changed, the callback function can be invoked to notify the info. Signed-off-by: Wu Zheng <[email protected]>
Network devices connect/disconnect are implemented. It based on connman and wraps the D-Bus APIs of connman. Signed-off-by: Wu Zheng <[email protected]>
Get services list are implemented. It based on connman and wraps the D-Bus APIs of connman. The user can use the API to get services list. Signed-off-by: Wu Zheng <[email protected]>
Add sol-connman to compile files, so that sol-connman can be compiled. Signed-off-by: Wu Zheng <[email protected]>
The test cases will test sol-connman APIs Signed-off-by: Wu Zheng <[email protected]>
The init and shutdown process of sol-connman need add to the init and shutdown process of sol-comms. Signed-off-by: Wu Zheng <[email protected]>
|
The patches have been closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so-connman is for implementing connection manager features.
The APIs should be implemented in Zephyr, connman and so on.
The patches are for implementing sol-connman basic APIs to connman.
the connman D-Bus APIs are wrapped in the so-connman APIs.
The user can use the so-connman APIs to control connman.
Signed-off-by: Wu Zheng [email protected]