This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Fix Clang warnings about printf format mismatches #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the API version numbers are declared as plain integer literals, so using %hu is wrong. They are int, not unsigned short. The booleans are not to be printed as %hhu. Signed-off-by: Thiago Macieira <[email protected]>
|
Please explain the failure. |
|
why boolean not to be print with If we can't find a way to print boolean, then at least provide |
|
Because bool is not uint8_t, therefore %hhu is incorrect. I can introduce a cast, instead. |
|
I'm postponing this until I convert more of the Linux→Unix checks. There may be more of these. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the API version numbers are declared as plain integer literals,
so using %hu is wrong. They are int, not unsigned short.
The booleans are not to be printed as %hhu.
Signed-off-by: Thiago Macieira [email protected]