Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

V1 - Export Files from Dev-App #130

Merged
merged 2 commits into from
Jul 11, 2016

Conversation

preetham
Copy link
Contributor

@preetham preetham commented Jul 8, 2016

This PR is part of implementation of task #47 .

  • Files can now be exported from desired Dev-App working repository.
  • HTTP GET request sent to 'api/file/download' with query string as the path of file to be downloaded will return a 'Save As' dialog in the browser.
  • Only a single file at a time can be downloaded. No support for direct folder download.
  • File inclusion vulnerability is put in check so that files outside Dev-App's repos folder (such as /etc/passwd ) cannot be accessed.
  • SetTimeout() is used for making this work in Firefox.

Kamidi Preetham added 2 commits July 8, 2016 20:27
@brunobottazzini
Copy link
Contributor

LGTM

@brunobottazzini brunobottazzini merged commit fe3688a into solettaproject:master Jul 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants