Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

editor: fix remove-file issue #102

Closed
wants to merge 1 commit into from

Conversation

preetham
Copy link
Contributor

@preetham preetham commented May 11, 2016

  • After a file is removed it's entry is deleted from the directory view(jsTree) but the contents of it remain in the editor which enable us to make some more edits and save it again. This time the file is saved but the directory view is not updated.
  • This fix now uses refresh() function to update the directory view whenever saveFileManually() is executed.
  • gitignore file should contain repos/* as an entry as the edits done by a user in his own project need not be included in a "source code" update commit.

Signed-off-by: Kamidi Preetham [email protected]

@preetham preetham changed the title editor:fix remove-file issue editor: fix remove-file issue May 11, 2016
@@ -1,3 +1,4 @@
/node_modules/*
/client/libs/*
/sessions
/repos/*
Copy link
Contributor

@brunobottazzini brunobottazzini May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a default repo commited that is the demo one. I think It does not make sense putting repos in .gitignore. Unless we implemented this feature -> #82 then we could add repos into .gitignore file.

Signed-off-by: Kamidi Preetham <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants