NH-53257 Use docker instead of compose to run test containers #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix otel_config_propagator_test.rb failures by requiring dependency and setting a dummy service key
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cheempz
changed the title
xuan-cao-swi
previously approved these changes
Aug 3, 2023
Rakefile
Outdated
Comment on lines
49
to
51
| --volume $PWD:/code/ruby-solarwinds --workdir /code/ruby-solarwinds \ | ||
| --entrypoint test/test_setup.sh -e RUN_TESTS=1 \ | ||
| --name ruby_sw_apm_#{args.os}_#{args.ruby_version} ruby_sw_apm_#{args.os}_#{args.ruby_version}" | ||
| --name ruby_sw_apm_#{args.tag} ruby:#{args.tag}" |
There was a problem hiding this comment.
It would be nice to have choice of platform like
cmd = "docker run --rm --tty \
--volume $PWD:/code/ruby-solarwinds --workdir /code/ruby-solarwinds \
--entrypoint test/test_setup.sh -e RUN_TESTS=1 --platform=#{args.platform} \
--name ruby_sw_apm_#{args.tag} ruby:#{args.tag}"
but please ignore if too much arguments for rake task
There was a problem hiding this comment.
That makes sense, to allow running tests on alpine :). Added!
Remove test container name clash
|
Pushed 525df31 because I ran into an issue setting up VSCode Ruby LSP extension (pretty cool, recommend it) which boiled down to the global bundle "without" config that interfered with the extension's gem installation. Looking more, found we can actually set the config at local level and take advantage of the environment vars set in official ruby containers, as noted in the updated PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://swicloud.atlassian.net/browse/NH-53257
Use docker to run test containers. This is to address the problem that with the original compose-based way, it's not possible to run multiple containers via the rake tasks because each
docker_devanddocker_teststask invocation will tear the entire compose stack down. I thought about using compose profiles or separate compose files, but just using plain docker run seemed the simplest given current use case. Also stop setting a name for the test containers since that could cause run failure due to name collision, and seemed not needed for these disposable containers.Fix the otel_config_propagator_test.rb failures by requiring
solarwinds_apm/configand setting a dummy service key. This issue was seen when running just this single test file, we should probably improve the test setup/teardown so that there aren't these masked dependencies.No longer need to set global bundler config, since official ruby containers use the BUNDLE_APP_CONFIG env var which bypasses collisions between config set on the host machine and set within the container. So added it along with BUNDLE_SILENCE_ROOT_WARNING to the dev container.