Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP/PoC NH-78295 Decouple settings management #96

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

WIP/PoC NH-78295 Decouple settings management #96

wants to merge 40 commits into from

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented May 29, 2024 •
edited
Loading

WIP

Adds settingsManager struct to run (WIP) settings get/update/delete tickers, which should be there instead of having grpcReporter both manage settings and send telemetry.

TODO:

// (A) Excise grpcReporter's call to oboe.UpdateSetting but keep LegacyRegistry updates.
//     Also get grpcReporter to return collector settings to this Manager.
// or
// (B) Add new GetSettings interface to let grpcReporter keep all original behaviour

@tammy-baylis-swi
HasLambdaEnv more public
bfffc2f
@tammy-baylis-swi
WIP add UpdateSettingFromFile called by agent ticker
55bae2e
@tammy-baylis-swi
Move ticker to Oboe
5f6e257
@tammy-baylis-swi
Add settingLambda to unmarshall settings json
67d2f5c
@tammy-baylis-swi
UpdateSettingFromFile uses JSON to merge settings
7bd3ab4
@tammy-baylis-swi
Add newSettingLambdaFromFile
fb8c8e3
@tammy-baylis-swi
UpdateSettingFromFile returns bool for success
d9156ff
@tammy-baylis-swi
Revert "UpdateSettingFromFile returns bool for success"
331c73c 
This reverts commit d9156ff.
@tammy-baylis-swi
UpdateSettingFromFile uses UpdateSetting
cd1632d
@tammy-baylis-swi
Revert "HasLambdaEnv more public"
42d2b33 
This reverts commit bfffc2f.
@tammy-baylis-swi
Mv ArgsToMap to general utils
c041b6d
@tammy-baylis-swi
Add FileBasedWatcher
cf63ef9
@tammy-baylis-swi
Fix Watcher ticker start/stop
4164796
@tammy-baylis-swi
Rm debug lines
8dccd78
@tammy-baylis-swi
Rm Fbw init for now
8efdc1b
@tammy-baylis-swi
Add tests
2c64608
@tammy-baylis-swi
More tests
ea018e9
@tammy-baylis-swi
Add comments
15f719c
@tammy-baylis-swi
Add errchecks
189c022
@tammy-baylis-swi
Update field int types
6cb38cd
@tammy-baylis-swi
Add FileBasedWatcher settingsCache
79eb573
@tammy-baylis-swi
Add errcheck
f0fe14a
@tammy-baylis-swi
Fix FileWatcher cache get/set
c2e4599
@tammy-baylis-swi
Comment out FileWatcher UpdateSetting call
837d579
@tammy-baylis-swi
Watcher cachesize 10kb
a2e93a2
@tammy-baylis-swi
Fix pointer
69adc5e
@tammy-baylis-swi
FileBasedWatcher does not cache nor updatesetting
c8d5d25
@tammy-baylis-swi
WIP Add SettingsManager
fca445b
@tammy-baylis-swi
WIP add stubs
e65f352
@tammy-baylis-swi
Fix logging, style
eb061c2
@tammy-baylis-swi tammy-baylis-swi changed the title NH-78295 Decouple settings management WIP/PoC NH-78295 Decouple settings management May 29, 2024
Base automatically changed from NH-78295-settings-from-file to lambda May 30, 2024 15:35
@tammy-baylis-swi tammy-baylis-swi changed the base branch from lambda to main May 30, 2024 17:21
@tammy-baylis-swi tammy-baylis-swi changed the base branch from main to lambda May 30, 2024 17:33
@tammy-baylis-swi tammy-baylis-swi changed the base branch from lambda to main May 30, 2024 20:50
@tammy-baylis-swi tammy-baylis-swi changed the base branch from main to lambda May 30, 2024 20:50
Base automatically changed from lambda to main July 22, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tammy-baylis-swi