Prune stale threads' cache from Dify Plugin's Persistent Storage

[djjimba]

Added logic to prune stale threads' cache from Dify Plugin's Persistent Storage

Summary by CodeRabbit

• バグ修正
  • 有効期限切れメッセージのフィルタリング後、キャッシュ内にメッセージが残っていない場合はキャッシュが削除されるようになりました。

[coderabbitai]

Walkthrough

SlackEndpoint クラスの _load_cached_history メソッドが修正され、キャッシュから期限切れメッセージを除外後、メッセージが空の場合はキャッシュキーを削除し、メッセージが残る場合のみキャッシュを更新するよう条件分岐が追加されました。

Changes

ファイル	変更内容概要
endpoints/slack.py	_load_cached_history メソッドのキャッシュ更新ロジックを条件分岐で修正。メッセージが空の場合はキャッシュ削除、残る場合は更新。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SlackEndpoint
    participant CacheStorage

    User->>SlackEndpoint: _load_cached_history呼び出し
    SlackEndpoint->>CacheStorage: キャッシュから履歴取得
    SlackEndpoint->>SlackEndpoint: 期限切れメッセージを除外
    alt メッセージが残る場合
        SlackEndpoint->>CacheStorage: キャッシュを更新
    else メッセージが空の場合
        SlackEndpoint->>CacheStorage: キャッシュキーを削除
    end
    SlackEndpoint-->>User: フィルタ済み履歴を返却

Loading

Estimated code review effort

2 (30–90分)

Poem

うさぎがピョンとキャッシュを整理、
空なら削除で身軽な旅路。
メッセージ残ればそっと保存、
Slackの履歴も春風のよう。
コードの森で今日も一歩、
ふわふわしっぽでありがとう！ 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a82dfe8 and 3f86e76.

📒 Files selected for processing (1)

• endpoints/slack.py (1 hunks)

🔇 Additional comments (1)

endpoints/slack.py (1)

215-219: キャッシュプルーニングロジックの実装が適切です

期限切れメッセージのフィルタリング後に空になったキャッシュエントリを削除する条件分岐の追加は、以下の利点があります：

• ストレージの効率化：空のデータ構造を保存する代わりにキー自体を削除
• メモリ使用量の削減：不要なキャッシュエントリの除去
• PRの目的（古いスレッドキャッシュのプルーニング）との整合性

エラーハンドリングも既存の構造を維持しており、堅牢な実装となっています。

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.