Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snote when an oper sets a chm_hidden mode #303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

snote when an oper sets a chm_hidden mode #303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71dbc68
snote when an oper sets a chm_hidden mode
jesopo Dec 4, 2021
8ca4ef8
snote if mode change requires oper priv, not just if it is hidden
jesopo Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ircd/chmode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1538,8 +1538,13 @@ set_channel_mode(struct Client *client_p, struct Client *source_p,
*mbuf = '\0';

if(cur_len > mlen)
{
sendto_channel_local_priv(IsServer(source_p) ? fakesource_p : source_p,
send_flags, priv, chptr, "%s %s", modebuf, parabuf);
if (priv != NULL && IsClient(source_p))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to be the test you think it is? priv is only set to non-null when flags is ONLY_OPERS (in which case it is set to auspex:cmodes, which is not the priv used to set the mode), and the only mode changes with mems set to ONLY_OPERS are chm_hidden modes.

sendto_realops_snomask(SNO_GENERAL, L_ALL, "%s used %s to set modes on %s: %s",
get_oper_name(source_p), priv, chptr->chname, &modebuf[mlen]);
}
else
continue;

Expand Down Expand Up @@ -1575,8 +1580,14 @@ set_channel_mode(struct Client *client_p, struct Client *source_p,

*mbuf = '\0';
if(cur_len > mlen)
{
sendto_channel_local_priv(IsServer(source_p) ? fakesource_p : source_p,
send_flags, priv, chptr, "%s %s", modebuf, parabuf);
if (priv != NULL && IsClient(source_p))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

sendto_realops_snomask(SNO_GENERAL, L_ALL, "%s used %s to set modes on %s: %s",
get_oper_name(source_p), priv, chptr->chname, &modebuf[mlen]);
}

}

/* only propagate modes originating locally, or if we're hubbing */
Expand Down