Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use bpf-entrypoint feature #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use bpf-entrypoint feature #27

wants to merge 1 commit into from

Conversation

buffalojoec
Copy link

The rest of the programs we've written in BPF have swapped no-entrypoint for bpf-entrypoint, where the feature is now additive to enable the program ELF's entrypoint binding.

This change brings the Stake program into that same pattern.

@buffalojoec buffalojoec requested a review from 2501babe December 19, 2024 10:52
febo
febo approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One little comment: we will need to build the program with the bpf-entrypoint feature enabled so the clients tests work:

At the moment it is not an issue since we don't have clients tests, so we could do it either in this PR or in a future one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@febo febo febo approved these changes

@2501babe 2501babe Awaiting requested review from 2501babe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buffalojoec @febo