Use RpcRequest in createRpcMessage helper #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 56802c2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 17, 2024
lorisleiva
force-pushed
the
loris/move-rpc-request-response
branch
from
164e37c to
ba813b0
Compare
lorisleiva
force-pushed
the
loris/use-rpc-request-in-create-rpc-message
branch
from
f892da6 to
66909f8
Compare
lorisleiva
force-pushed
the
loris/move-rpc-request-response
branch
from
ba813b0 to
a9597b9
Compare
lorisleiva
force-pushed
the
loris/use-rpc-request-in-create-rpc-message
branch
from
66909f8 to
2095d45
Compare
lorisleiva
force-pushed
the
loris/move-rpc-request-response
branch
from
a9597b9 to
f1cee41
Compare
lorisleiva
force-pushed
the
loris/use-rpc-request-in-create-rpc-message
branch
from
2095d45 to
d064590
Compare
lorisleiva
force-pushed
the
loris/move-rpc-request-response
branch
from
f1cee41 to
580ac5d
Compare
lorisleiva
force-pushed
the
loris/use-rpc-request-in-create-rpc-message
branch
from
d064590 to
a981e35
Compare
lorisleiva
force-pushed
the
loris/move-rpc-request-response
branch
from
580ac5d to
b965d83
Compare
lorisleiva
force-pushed
the
loris/use-rpc-request-in-create-rpc-message
branch
from
a981e35 to
29a38f0
Compare
This was referenced Oct 21, 2024
lorisleiva
changed the base branch from
loris/move-rpc-request-response
to
graphite-base/3394
lorisleiva
force-pushed
the
loris/use-rpc-request-in-create-rpc-message
branch
from
29a38f0 to
56802c2
Compare
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the arguments of the
createRpcMessagehelper function so that it accepts anRpcRequestdirectly instead of accepting all the components inside a request (i.e.methodNameandparams).We discussed this a little while ago with @mcintyre94 as, without this change, you sometimes need to express a request as an object and sometimes as its deconstructed version. This PR stack aims to embrace the
RpcRequestobject wherever applicable.