This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
forked from qmonnet/rbpf
-
Notifications
You must be signed in to change notification settings - Fork 180
Add new syscall
instruction to interpreter and jitter
#621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
==========================================
- Coverage 90.09% 89.61% -0.49%
==========================================
Files 22 22
Lines 9726 10002 +276
==========================================
+ Hits 8763 8963 +200
- Misses 963 1039 +76 ☔ View full report in Codecov by Sentry. |
Lichtso
reviewed
Oct 22, 2024
Lichtso
reviewed
Oct 22, 2024
LucasSte
force-pushed
the
exec-1
branch
2 times, most recently
from
October 22, 2024 21:23
3fc3510
to
e997952
Compare
Can you move the execution tests with: let config = Config {
test_syscall_asm!(
enabled_sbpf_versions: SBPFVersion::V1..=SBPFVersion::V1,
..Config::default()
}; down to the And remove the syscall parameters from |
Lichtso
reviewed
Oct 28, 2024
Lichtso
approved these changes
Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #620 (implementing SIMD-0178) and introduces the new syscall instruction to the interpreter and jitter. It revamps the execution tests to deal with two syscall models and write extra tests for the changed code fragments.