This repository has been archived by the owner on Feb 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Add support for validator linked roles #81
Open
ryanchern
wants to merge
17
commits into
solana-labs:main
Choose a base branch
from
ryanchern:validator-linked-roles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core functionality working, still yet to add signature verification and epoch refreshes
@@ -30,7 +30,7 @@ export class MatchdayDiscordUserController { | |||
constructor( | |||
private readonly matchdayDiscordUserService: MatchdayDiscordUserService, | |||
private readonly configService: ConfigService, | |||
) {} | |||
) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this wasn't an intended change I'd revert.
validatorDiscordUsers.forEach(async (user) => { | ||
const publicKey = user.publicKeyStr; | ||
try { | ||
await axios.post(`http://localhost:3001/verify-gossip-keypair/${publicKey}/identitykeyplacerholder/discordauthplaceholder`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use relative paths here? Local host won't work in production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any ENV variables you could use to populate this if a relative link won't work?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the validator Discord linked role-related controller and endpoints:
/verify-gossip-keypair/:publicKey/:discordAuthorizationCode
endpoint for handling new requests to be verified for the linked rolesThe following roles are available:
is_testnet_validator
-- true if the validator is currently a validator on testnetis_active_testnet_validator
-- true if the validator has voted within the last epoch (with respect to slot number differentials, not discrete epochs) on testnetis_mainnet_validator
-- true if the validator is currently a validator on testnetis_active_mainnet_validator
-- true if the validator has voted within the last epoch (with respect to slot number differentials, not discrete epochs) on mainnetmainnet_activated_stake_threshold
-- true if the stake weight associated with this account on mainnet is greater than or equal to a given threshold, currently 5,000 SOLExample Discord user role:
Metadata information is refreshed once every 2 days, approximately the duration of each Solana epoch.
Requires 4 new environment variables: