-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMD-0180: Leader Schedule Migration #180
base: main
Are you sure you want to change the base?
Conversation
b14c2bf
to
deccb77
Compare
up by first finding the vote account for the designated vote pubkey for a | ||
particular leader slot in bank epoch stakes. Bank epoch stakes are keyed by | ||
leader schedule epoch and therefore the vote account state should be retrieved | ||
by looking up the epoch stakes for the current epoch. Since only valid vote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming my understanding that this shouldn't cause an issue at epoch boundary:
Since the leader schedule is generated an epoch before, if we receive a shred from epoch E + 1, we can still use the root bank from epoch E to perform the vote account -> node pubkey lookup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct. We can only validate shreds for epoch E + 1 once we have a root bank in epoch E
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.