Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enkrypt wallet #82

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Add enkrypt wallet #82

merged 2 commits into from
Nov 21, 2024

Conversation

Abyscuit
Copy link
Contributor

@Abyscuit Abyscuit commented Oct 31, 2024 •
edited by catalinred
Loading

request for review to add Enkrypt Wallet to https://solana.com/solana-wallets
This fixes #91.

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024

@Abyscuit is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@catalinred
Copy link
Collaborator

@Abyscuit I took a quick look at the wallet’s repo, supported chains on the website, and the documentation, but I didn’t see any mention of existing support for the Solana blockchain.

It looks like the support for Solana was recently added and this might explain it. Could you open an issue once you've addressed the comments above? That way, we can continue the discussion there and proceed with a review for this PR afterwards. Thank you.

@Abyscuit Abyscuit mentioned this pull request Nov 5, 2024
Closed
@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
solana-com ✅ Ready (Inspect) Visit Preview Nov 21, 2024 0:21am

catalinred
catalinred requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@catalinred catalinred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abyscuit We reviewed the submission and before merging this to main, could you move the Encrypt object to the end of the walletData array?

@Abyscuit
Copy link
Contributor Author

@catalinred I have moved the object to the end of walletData.

@catalinred catalinred merged commit 3b861ba into solana-foundation:main Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinred catalinred catalinred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Enkrypt wallet
2 participants
@Abyscuit @catalinred