Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Hindi translation #120

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

devansh-m12
Copy link
Contributor

@devansh-m12 devansh-m12 commented Nov 23, 2024

I made corrections to the translation to make it more accurate and refined. take a look @catalinred

fixes #119

Screenshot 2024-11-23 at 12 20 05 PM

Copy link

vercel bot commented Nov 23, 2024

@devansh-m12 is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@catalinred
Copy link
Collaborator

@devansh-m12, the ~ {number} string is a remnant indeed. I just ran a quick codebase search and I found this extra string in other translation files such as tr or vi, besides hi.

Can you update and test the changes for those files as well?

@devansh-m12
Copy link
Contributor Author

sure @catalinred , done they were in Japnese too added the changes

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
solana-com ✅ Ready (Inspect) Visit Preview Nov 23, 2024 6:16pm

@catalinred catalinred changed the title Improve the HindiTranslation Improve the Hindi translation Nov 23, 2024
Copy link
Collaborator

@catalinred catalinred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devansh-m12

@catalinred catalinred merged commit eb142b2 into solana-foundation:main Nov 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Hindi Language Translation in Community Wayfinding
2 participants