Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/rpc] fix incorrect space labels #628

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

nickfrosty
Copy link
Collaborator

Problem

Several rpc docs locations mislabel the space value as size

Summary of Changes

  • corrected space labels
  • updated some of the rpc responses too

Related: https://github.com/solana-labs/web3.js-issue-conveyer/issues/3

@nickfrosty nickfrosty requested a review from ZYJLiu as a code owner November 19, 2024 16:46
@nickfrosty nickfrosty merged commit 99ec3dd into main Nov 19, 2024
2 checks passed
@nickfrosty nickfrosty deleted the docs-rpc-space-vs-size branch November 19, 2024 16:48
@@ -93,7 +93,7 @@ The result will be a JSON object with `value` equal to an array of:
\(and is strictly read-only\)
- `rentEpoch: <u64>` - the epoch at which this account will next owe rent, as
u64
- `space: <u64>` - the data size of the account
- `size: <u64>` - the data size of the account
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is being changed from space to size, while the rest are size to space. Is this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants