-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workflow]add workflow to check link validation #370
base: main
Are you sure you want to change the base?
Conversation
This is a good idea! There seems to be some false positives though:
But https://solana.com/docs/core/programs exists. Do you know why this is? Separately: rather than listing what works, it's better to only list what has failed. That allows us to scan test results and find failures very quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above.
The checker determines the validity of a link based on whether it can be accessed successfully. When it checks This behavior is inconsistent with the expected check of the address https://solana.com/docs/core/programs. I’ve added a configuration file that replaces links starting with Also, I have set the checker to quiet mode, so it will only output the invalid links. Is there anything else you’d like to configure? For example, ignore certain links... |
This took me a while to understand, but I think you're saying -
is that correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just following this up - can you please answer the comment in #370 (comment) ?
This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days. |
Problem:
Some links may be invalid in the markdown files.
Summary of Changes:
related issue
#12