chore: migrate to eslint v9 flat config

.github/workflows/workflow.yml

@@ -20,21 +20,6 @@ jobs:
           key: node_modules-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
       - if: steps.node-modules-cache.outputs.cache-hit != 'true'
         run: npm ci
-  lint:
-    name: 'Linting'
-    needs: install
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version: ${{ env.NODE_VERSION }}
-      - name: 'Restoring NPM modules from cache'
-        uses: actions/cache@v4
-        with:
-          path: ./node_modules
-          key: node_modules-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
-      - run: npm run lint
   build-solace-message-client:
     name: 'Building solace-message-client'
     needs: install
@@ -68,6 +53,26 @@ jobs:
         with:
           name: solace-message-client-api
           path: dist/solace-message-client-api
+  lint:
+    name: 'Linting'
+    needs: build-solace-message-client
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+      - name: 'Restoring NPM modules from cache'
+        uses: actions/cache@v4
+        with:
+          path: ./node_modules
+          key: node_modules-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
+      - name: 'Downloading solace-message-client'
+        uses: actions/download-artifact@v4
+        with:
+          name: solace-message-client
+          path: dist/@solace-community/angular-solace-message-client
+      - run: npm run lint
   build-tryme-app:
     name: 'Building TryMe App'
     needs: build-solace-message-client

angular.json

@@ -42,7 +42,8 @@
             "lintFilePatterns": [
               "projects/solace-message-client/**/*.ts",
               "projects/solace-message-client/**/*.html"
-            ]
+            ],
+            "eslintConfig": "projects/solace-message-client/eslint.config.js"
           }
         }
       }
@@ -133,7 +134,8 @@
             "lintFilePatterns": [
               "apps/solace-message-client-testing-app/**/*.ts",
               "apps/solace-message-client-testing-app/**/*.html"
-            ]
+            ],
+            "eslintConfig": "apps/solace-message-client-testing-app/eslint.config.js"
           }
         }
       }

apps/solace-message-client-testing-app/eslint.config.js

@@ -0,0 +1,32 @@
+// @ts-check
+const tseslint = require("typescript-eslint");
+const rootConfig = require("../../eslint.config.js");
+
+module.exports = tseslint.config(
+  ...rootConfig,
+  {
+    files: ["**/*.ts"],
+    rules: {
+      "@angular-eslint/directive-selector": [
+        "error",
+        {
+          type: "attribute",
+          prefix: ["app"],
+          style: "camelCase",
+        },
+      ],
+      "@angular-eslint/component-selector": [
+        "error",
+        {
+          type: "element",
+          prefix: ["app"],
+          style: "kebab-case",
+        },
+      ],
+    },
+  },
+  {
+    files: ["**/*.html"],
+    rules: {},
+  },
+);

apps/solace-message-client-testing-app/src/app/autofocus.directive.ts

@@ -4,9 +4,7 @@ import {asyncScheduler} from 'rxjs';
 /**
  * Use this directive to set the focus to the host element.
  */
-@Directive({
-  selector: '[appAutoFocus]'
-})
+@Directive({selector: '[appAutoFocus]'})
 export class AutofocusDirective {
 
   constructor(private _host: ElementRef<HTMLElement>) {

apps/solace-message-client-testing-app/src/app/location.service.ts

@@ -12,6 +12,6 @@ export class LocationService {
     if (options.clearConnectProperties) {
       SessionConfigStore.clear();
     }
-    this._router.navigate(['/']).then(() => location.reload());
+    void this._router.navigate(['/']).then(() => location.reload());
   }
 }

apps/solace-message-client-testing-app/src/app/login/login.component.ts

@@ -68,14 +68,14 @@ export class LoginComponent implements OnDestroy {
   public onLogin(): void {
     const oAuthEnabled = this.form.get(AUTHENTICATION_SCHEME)!.value === AuthenticationScheme.OAUTH2;
     const sessionConfig: SolaceMessageClientConfig = {
-      url: this.form.get(URL)!.value ?? undefined,
-      vpnName: this.form.get(VPN_NAME)!.value ?? undefined,
-      userName: this.form.get(USER_NAME)!.value ?? undefined,
-      password: this.form.get(PASSWORD)!.value ?? undefined,
-      reapplySubscriptions: this.form.get(REAPPLY_SUBSCRIPTIONS)!.value ?? undefined,
-      reconnectRetries: this.form.get(RECONNECT_RETRIES)!.value ?? undefined,
-      connectRetries: this.form.get(RECONNECT_RETRIES)!.value ?? undefined,
-      authenticationScheme: this.form.get(AUTHENTICATION_SCHEME)!.value ?? undefined,
+      url: this.form.get(URL)!.value as string | string[],
+      vpnName: this.form.get(VPN_NAME)!.value as string,
+      userName: this.form.get(USER_NAME)!.value as string,
+      password: this.form.get(PASSWORD)!.value as string,
+      reapplySubscriptions: this.form.get(REAPPLY_SUBSCRIPTIONS)!.value as boolean,
+      reconnectRetries: this.form.get(RECONNECT_RETRIES)!.value as number,
+      connectRetries: this.form.get(RECONNECT_RETRIES)!.value as number,
+      authenticationScheme: this.form.get(AUTHENTICATION_SCHEME)!.value as AuthenticationScheme,
       accessToken: oAuthEnabled ? promptForAccessToken : undefined,
     };
 
@@ -108,4 +108,3 @@ export class LoginComponent implements OnDestroy {
     this._destroy$.next();
   }
 }
-

apps/solace-message-client-testing-app/src/app/message-list-item/message-list-item.component.ts

@@ -63,19 +63,17 @@ function formatMessageType(messageType: MessageType): string {
       return `MAP (${messageType})`;
     case MessageType.STREAM:
       return `STREAM (${messageType})`;
-    default:
-      return `UNKNOWN (${messageType})`;
   }
 }
 
 function getContent(envelope: MessageEnvelope): string | undefined {
-  const encoding = envelope.headers.get('Content-Encoding');
+  const encoding = envelope.headers.get('Content-Encoding') as string;
 
   switch (envelope.message.getType()) {
     case MessageType.BINARY:
       return decode(envelope.message.getBinaryAttachment(), encoding);
     case MessageType.TEXT:
-      return decode(envelope.message.getSdtContainer()!.getValue(), encoding);
+      return decode(envelope.message.getSdtContainer()!.getValue() as string, encoding);
     default:
       return undefined;
   }

apps/solace-message-client-testing-app/src/app/publisher/publisher.component.ts

@@ -91,7 +91,7 @@ export class PublisherComponent implements OnDestroy {
         takeUntil(this._destroy$),
       )
       .subscribe({
-        error: error => this.publishError = error,
+        error: (error: unknown) => this.publishError = `${error}`, // eslint-disable-line @typescript-eslint/restrict-template-expressions
       });
   }
 
@@ -107,8 +107,8 @@ export class PublisherComponent implements OnDestroy {
 
   private publish$(): Observable<any> {
     try {
-      const destination = this.form.get(DESTINATION)!.value;
-      const destinationType: DestinationType = this.form.get(DESTINATION_TYPE)!.value;
+      const destination = this.form.get(DESTINATION)!.value as string;
+      const destinationType = this.form.get(DESTINATION_TYPE)!.value as DestinationType;
       const message: Data | undefined = this.readMessageFromUI();
       const publishOptions: PublishOptions = this.readPublishOptionsFromUI();
 
@@ -148,7 +148,7 @@ export class PublisherComponent implements OnDestroy {
   }
 
   public get requestReply(): boolean {
-    return this.form.get(REQUEST_REPLY)!.value;
+    return this.form.get(REQUEST_REPLY)!.value as boolean;
   }
 
   public get publishing(): boolean {
@@ -158,12 +158,12 @@ export class PublisherComponent implements OnDestroy {
   private readPublishOptionsFromUI(): PublishOptions {
     return {
       headers: this.readHeadersFromUI(),
-      deliveryMode: this.form.get(DELIVERY_MODE)!.value,
+      deliveryMode: this.form.get(DELIVERY_MODE)!.value as MessageDeliveryModeType,
     };
   }
 
   private readMessageFromUI(): Data | undefined {
-    const message = this.form.get(MESSAGE)!.value;
+    const message = this.form.get(MESSAGE)!.value as string | undefined;
     if (!message) {
       return undefined;
     }
@@ -176,13 +176,13 @@ export class PublisherComponent implements OnDestroy {
     }
   }
 
-  private readHeadersFromUI(): Map<string, any> | undefined {
-    const headers: string = this.form.get(HEADERS)!.value;
+  private readHeadersFromUI(): Map<string, string | boolean | number> | undefined {
+    const headers = this.form.get(HEADERS)!.value as string;
     if (!headers.length) {
       return undefined;
     }
 
-    const headerMap = new Map();
+    const headerMap = new Map<string, string | boolean | number>();
     headers.split(';').forEach(keyValue => {
       const [key, value] = keyValue.split('->');
       if (value === 'true' || value === 'false') {