Skip to content

Commit

Permalink
chore(components): remove deprecated API ObserveOptions#requestTimeout
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Removing the deprecated API `ObserveOptions#requestTimeout` introduced a breaking change.

To migrate, use `ObserveOptions#subscribeTimeout` instead.
  • Loading branch information
danielwiehl authored and Marcarrian committed Aug 16, 2022
1 parent 7f9125c commit 813cf2d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -309,13 +309,6 @@ export class NullSolaceMessageClient implements SolaceMessageClient {
* Control how to observe a topic.
*/
export interface ObserveOptions {
/**
* Specifies the maximum time (in milliseconds) to wait for the destination to be subscribed.
* If specified, overrides the global timeout as set via {@link SessionProperties#readTimeoutInMsecs}.
*
* @deprecated This API will be removed in a future release. Instead, use {@link #subscribeTimeout} instead.
*/
requestTimeout?: number;
/**
* Specifies the maximum time (in milliseconds) to wait for the destination to be subscribed.
* If specified, overrides the global timeout as set via {@link SessionProperties#readTimeoutInMsecs}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ export class ɵSolaceMessageClient implements SolaceMessageClient, OnDestroy {
topic,
true,
subscribeCorrelationKey,
observeOptions?.subscribeTimeout ?? observeOptions?.requestTimeout,
observeOptions?.subscribeTimeout,
);
return whenSubscribed;
}
Expand Down

0 comments on commit 813cf2d

Please sign in to comment.