Skip to content

Redirection cookie handling tests for issue #2671 #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Redirection cookie handling tests for issue #2671 #2672

wants to merge 2 commits into from

Conversation

Zerkath
Copy link

@Zerkath Zerkath commented Sep 23, 2025

Tests for #2671 which are now failing with the following output:

- should pass cookies during redirections *** FAILED *** (13 milliseconds)
  Vector() did not contain element "session" (in Checkpoint) at FollowRedirectsBackendTest.scala:90
  Vector() did not contain element "session" (in Checkpoint) at FollowRedirectsBackendTest.scala:90
  Vector() did not contain element "session" (in Checkpoint) at FollowRedirectsBackendTest.scala:90
  Vector() did not contain element "session" (in Checkpoint) at FollowRedirectsBackendTest.scala:90
  Vector() did not contain element "session" (in Checkpoint) at FollowRedirectsBackendTest.scala:90
  Vector(session=final) did not equal List(0-fuzz=, 1-fuzz=, 2-fuzz=, 3-fuzz=, 4-fuzz=, session=final) (in Checkpoint) 

at FollowRedirectsBackendTest.scala:118 (FollowRedirectsBackendTest.scala:119)

Before submitting pull request:

  • Check if the project compiles by running sbt compile
  • Verify docs compilation by running sbt compileDocs
  • Check if tests pass by running sbt test
  • Format code by running sbt scalafmt

@Zerkath
test: redirection cookie behavior ignoring empty sensitive headers set
cff184f 
Redirects do not apply set-cookie in the request chain meaning
multistep request chains that track state will be missing cookies in the
middle of redirection, only real alternative is manual control

After redirection chain completes any set-cookies that started or were
in the middle of the request chain get ignored. Only the last responses set-cookie's
will be applied. It is possible to collect the cookies / headers from
response.history, but adds complexity.
@Zerkath
test: improve test case for redirect, additional checks
82f6a48
@Zerkath Zerkath mentioned this pull request Sep 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Zerkath