test - increase test-monitoring delay and replace type by builtin.stat

Change-Id: Ib8970fd5d6588442b31018825dc69c21476d78a3

roles/health-check/test-monitoring/tasks/main.yaml

@@ -36,15 +36,15 @@
   register: zeo
   until: zeo.stdout != "" and "null" not in zeo.stdout
   retries: 60
-  delay: 2
+  delay: 4
 
   # config-update-nodepool-builder should at least trigger one tick for readiness.
 - name: Fetch a basic Nodepool metric exported by statsd
   ansible.builtin.shell: curl -k https://{{ prometheus_host }}/api/v1/query?query=nodepool_launch_ready | jq '.data.result[0].value[1]'
   register: nlr
   until: nlr.stdout != "" and "null" not in nlr.stdout
   retries: 60
-  delay: 2
+  delay: 4
 
 # Use a dictionary to trick Ansible into casting metrics to int/float
 - set_fact:

roles/setup-log-forwarding/tasks/install-logCLI.yaml

@@ -1,24 +1,24 @@
 ---
 - name: check if logCLI is present
-  ansible.builtin.shell: type logcli
-  register: logcli_exists
-  ignore_errors: true
+  ansible.builtin.stat:
+    path: "~/bin/logcli"
+  register: logcli_stat
 
 - name: Install logCLI
   block:
-  - name: download and unzip logCLI
-    ansible.builtin.unarchive:
-      src: "https://github.com/grafana/loki/releases/download/v2.9.2/logcli-linux-amd64.zip"
-      remote_src: yes
-      mode: a+x
-      dest: /tmp/
+    - name: download and unzip logCLI
+      ansible.builtin.unarchive:
+        src: "https://github.com/grafana/loki/releases/download/v2.9.2/logcli-linux-amd64.zip"
+        remote_src: yes
+        mode: a+x
+        dest: /tmp/
 
-  - name: ensure ~/bin exists
-    ansible.builtin.file:
-      path: ~/bin
-      state: directory
-      mode: '0755'
+    - name: ensure ~/bin exists
+      ansible.builtin.file:
+        path: ~/bin
+        state: directory
+        mode: "0755"
 
-  - name: move logCLI to ~/bin/
-    command: mv /tmp/logcli-linux-amd64 ~/bin/logcli
-  when: logcli_exists.rc > 0
+    - name: move logCLI to ~/bin/
+      command: mv /tmp/logcli-linux-amd64 ~/bin/logcli
+  when: not logcli_stat.stat.exists