-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DevnetClient implementation #1393
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kkawula/1323-devnet-remove-unknown-EXCLUDE #1393 +/- ##
=============================================================================
Coverage ? 84.87%
=============================================================================
Files ? 106
Lines ? 5370
Branches ? 0
=============================================================================
Hits ? 4558
Misses ? 812
Partials ? 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments, mostly stylistic, once those are addressed it will be good to go 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Closes #1387
Future improvements
Documentation adjustment and docs examples are addressed in this issue #1413
Introduced changes