Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DevnetClient implementation #1393

Merged
merged 68 commits into from
Aug 1, 2024
Merged

Conversation

kkawula
Copy link
Contributor

@kkawula kkawula commented Jul 11, 2024

Closes #1387

Future improvements

Documentation adjustment and docs examples are addressed in this issue #1413

Introduced changes

Impl Tests
Impersonation
Account balance
Blocks
Dump,load,restart
Postman
Predeployed contracts
Server config
Starknet time

  • This PR contains breaking changes

@kkawula kkawula changed the base branch from development to kkawula/1323-devnet-remove-unknown-EXCLUDE July 11, 2024 13:25
@kkawula kkawula marked this pull request as draft July 11, 2024 14:05
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 78.21782% with 44 lines in your changes missing coverage. Please review.

Please upload report for BASE (kkawula/1323-devnet-remove-unknown-EXCLUDE@daac695). Learn more about missing BASE report.

Additional details and impacted files
@@                              Coverage Diff                              @@
##             kkawula/1323-devnet-remove-unknown-EXCLUDE    #1393   +/-   ##
=============================================================================
  Coverage                                              ?   84.87%           
=============================================================================
  Files                                                 ?      106           
  Lines                                                 ?     5370           
  Branches                                              ?        0           
=============================================================================
  Hits                                                  ?     4558           
  Misses                                                ?      812           
  Partials                                              ?        0           
Files Coverage Δ
starknet_py/conftest.py 100.00% <ø> (ø)
starknet_py/devnet/devnet_client_models.py 100.00% <100.00%> (ø)
starknet_py/devnet/devnet_http_client.py 44.44% <44.44%> (ø)
starknet_py/devnet/devnet_rpc_schema.py 88.88% <88.88%> (ø)
starknet_py/devnet/devnet_client.py 40.00% <40.00%> (ø)

@kkawula kkawula requested a review from ddoktorski July 15, 2024 13:01
@kkawula kkawula marked this pull request as ready for review July 17, 2024 06:55
@kkawula kkawula requested a review from ddoktorski July 25, 2024 14:28
@kkawula kkawula changed the title Devnet client implementation Add DevnetClient implementation Jul 26, 2024
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, mostly stylistic, once those are addressed it will be good to go 💪

starknet_py/abi/v1/schemas.py Show resolved Hide resolved
starknet_py/devnet_utils/devnet_client.py Outdated Show resolved Hide resolved
starknet_py/devnet_utils/devnet_client.py Show resolved Hide resolved
.github/workflows/checks.yml Show resolved Hide resolved
starknet_py/devnet_utils/devnet_client.py Outdated Show resolved Hide resolved
starknet_py/devnet_utils/devnet_client.py Outdated Show resolved Hide resolved
starknet_py/devnet_utils/devnet_client.py Outdated Show resolved Hide resolved
starknet_py/devnet_utils/devnet_client_models.py Outdated Show resolved Hide resolved
starknet_py/devnet_utils/devnet_rpc_schema.py Outdated Show resolved Hide resolved
@kkawula kkawula requested a review from ddoktorski July 31, 2024 12:45
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

starknet_py/devnet_utils/devnet_client.py Outdated Show resolved Hide resolved
@kkawula kkawula merged commit 49fbb85 into development Aug 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement client for devnet API
2 participants