Skip to content

[Not for merge?] Cache path parsing #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Not for merge?] Cache path parsing #2548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion android/src/main/java/com/horcrux/svg/PathView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,33 @@
import android.graphics.Path;
import com.facebook.react.bridge.ReactContext;

import java.util.ArrayList;
import java.util.HashMap;

class ParsedPath {
final Path path;
final ArrayList<PathElement> elements;

ParsedPath(Path path, ArrayList<PathElement> elements) {
this.path = path;
this.elements = elements;
}
}

@SuppressLint("ViewConstructor")
class PathView extends RenderableView {
private Path mPath;

// This grows forever but for our use case (static icons) it's ok.
private static final HashMap<String, ParsedPath> sPathCache = new HashMap<>();

public PathView(ReactContext reactContext) {
super(reactContext);
PathParser.mScale = mScale;
mPath = new Path();
}

public void setD(String d) {
void setDByParsing(String d) {
mPath = PathParser.parse(d);
elements = PathParser.elements;
for (PathElement elem : elements) {
Expand All @@ -33,6 +49,17 @@ public void setD(String d) {
point.y *= mScale;
}
}
}

public void setD(String d) {
ParsedPath cached = sPathCache.get(d);
if (cached != null) {
mPath = cached.path;
elements = cached.elements;
} else {
setDByParsing(d);
sPathCache.put(d, new ParsedPath(mPath, elements));
}
invalidate();
}

Expand Down