fix: add new macos examples #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto @jakex7/fixMacosBuildTime
…nto @jakex7/fixMacosBuildTime
bohdanprog
commented
Jul 29, 2024
src/ReactNativeSVG.web.ts
Outdated
| @@ -156,7 +158,7 @@ function parseTransformProp( | |||
| transformArray.push(`matrix(${transform.join(' ')})`); | |||
| } else { | |||
| const stringifiedProps = transformsArrayToProps( | |||
| transform as TransformsStyle['transform'] | |||
| transform as TransformsStyleArray | |||
There was a problem hiding this comment.
The Test JS build / build (pull_request) build crashed without altering that type.
WoLewicki
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to avoid problems with GitHub workflows.
Create a new Macos example for new and old architecture.
Test Plan
Run GitHub workflows
Compatibility